papermark icon indicating copy to clipboard operation
papermark copied to clipboard

added the custom not found page

Open Pratham271 opened this issue 1 year ago • 12 comments

resolves #637

Pratham271 avatar Oct 04 '24 08:10 Pratham271

@Pratham271 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 04 '24 08:10 vercel[bot]

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

github-actions[bot] avatar Oct 04 '24 08:10 github-actions[bot]

@Pratham271 thanks for the contribution. would you mind signing the CLA as indicated above, please :)

mfts avatar Oct 04 '24 09:10 mfts

I have read the CLA Document and I hereby sign the CLA

Pratham271 avatar Oct 04 '24 11:10 Pratham271

@mfts but locally when I added 404 page it was not working properly. Can you explain me again please the changes that you suggested

Pratham271 avatar Oct 10 '24 06:10 Pratham271

/assign

Aditya-PS-05 avatar Oct 10 '24 13:10 Aditya-PS-05

Assigned to @Aditya-PS-05! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

oss-gg[bot] avatar Oct 10 '24 13:10 oss-gg[bot]

@mfts I have made the requested changes and now it is working fine for pages in the pages directory

Pratham271 avatar Oct 11 '24 09:10 Pratham271

@mfts Please review my pr.

Aditya-PS-05 avatar Oct 11 '24 17:10 Aditya-PS-05

@Pratham271 it's still causing an error.

CleanShot 2024-10-13 at 14 14 55@2x

Can you also share a screenshot of what this improved error page looks like?

mfts avatar Oct 13 '24 05:10 mfts

@mfts by mistake I removed a closing div just before the p tag let me make it right

Pratham271 avatar Oct 13 '24 06:10 Pratham271

@mfts Please merge this if everything is good.

Aditya-PS-05 avatar Oct 15 '24 12:10 Aditya-PS-05

@Pratham271 the search is currently not working. Also the buttons don't make sense, especially since an external visitor will see it and they may not have a papermark account so home, documents and settings are useless to them.

I will award you for your effort but close this PR for now.

/award 50

mfts avatar Oct 22 '24 06:10 mfts

Awarding Pratham271: 50 points 🕹️ Well done! Check out your new contribution on oss.gg/Pratham271

oss-gg[bot] avatar Oct 22 '24 06:10 oss-gg[bot]