papermark Feat/dataroom linktree

#69. @mfts. I have disabled the ability to create hierarchical datarooms. Please let me know if any changes are needed.

Jan 09 '24 08:01 digant2482

@digant2482 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

Jan 09 '24 08:01 vercel[bot]

I will review this PR @digant2482 cc @mfts

Jan 09 '24 08:01 Aashish-Upadhyay-101

hey @digant2482 I can still see some hierarchical's data room's code! could you clean those up first before I dive deeper into your code?

Jan 22 '24 16:01 Aashish-Upadhyay-101

hi @digant2482 please respond!

Feb 02 '24 14:02 Aashish-Upadhyay-101

hey @digant2482 I can still see some hierarchical's data room's code! could you clean those up first before I dive deeper into your code?

Hi @Aashish-Upadhyay-101, Noted

Feb 08 '24 12:02 digant2482

nice, @digant2482 ping me, after you are done cleaning up !

Feb 08 '24 16:02 Aashish-Upadhyay-101

nice, @digant2482 ping me, after you are done cleaning up !

Hey @Aashish-Upadhyay-101, all set for review, please let me know, you need any help

Feb 10 '24 13:02 digant2482

awesome !

Feb 10 '24 13:02 Aashish-Upadhyay-101

Hi @Aashish-Upadhyay-101, suggested changes are done

Feb 22 '24 10:02 digant2482

I am half way through the PR already, I will keep you updated here !

Feb 22 '24 14:02 Aashish-Upadhyay-101

@digant2482 hey, did you scope the Dataroom by Teams?

Feb 27 '24 18:02 Aashish-Upadhyay-101

@digant2482 hey, did you scope the Dataroom by Teams?

Yes

Feb 27 '24 20:02 digant2482

I noticed that the dataroom endpoints are outside the team folder in the api, and you are passing teamId via req.body could you please put the dataroom inside team folder and get the team's id from req.query ?

Feb 28 '24 05:02 Aashish-Upadhyay-101

I noticed that the dataroom endpoints are outside the team folder in the api, and you are passing teamId via req.body could you please put the dataroom inside team folder and get the team's id from req.query ?

Hi, Ashish, dataroom was not put inside teams folder because the end users also gets their datarooms from the same API (to avoid code duplication), now the end users won't have teamId, hence it is outside. Please let me know if you need more information

Feb 28 '24 09:02 digant2482

I have almost reviewed your code, I just have one thing to ask, you added a new verification system, could you explain me about why you add it and how you implemented it? email-authcode

Feb 28 '24 11:02 Aashish-Upadhyay-101

I have almost reviewed your code, I just have one thing to ask, you added a new verification system, could you explain me about why you add it and how you implemented it? email-authcode

The verification was implemented because of heirarchical datarooms, the things is: for heirarchical datarooms a separate URL was needed to be generated (for navigation purposes), since it was a separate URL it would bypass current verification system, that's was the reason for creation, but I will remove it since we don't need that.

Feb 28 '24 18:02 digant2482

I have almost reviewed your code, I just have one thing to ask, you added a new verification system, could you explain me about why you add it and how you implemented it? email-authcode

The verification was implemented because of heirarchical datarooms, the things is: for heirarchical datarooms a separate URL was needed to be generated (for navigation purposes), since it was a separate URL it would bypass current verification system, that's was the reason for creation, but I will remove it since we don't need that.

yes please do it and resolve the conflicts !

Feb 28 '24 19:02 Aashish-Upadhyay-101

Hi, @Aashish-Upadhyay-101, all requested changes are done.

However, regarding email-authcode I wanted ask @mfts that since email-verification to view document feature is for pro-users. Do we want to that for datarooms as well? If yes, can you please finalize that email-verification PR #197. Since you have made some changes to verification process, I will use the same for process for datarooms as well

Feb 29 '24 11:02 digant2482

However, regarding email-authcode I wanted ask @mfts that since email-verification to view document feature is for pro-users. Do we want to that for datarooms as well? If yes, can you please finalize that email-verification PR https://github.com/mfts/papermark/pull/197.

The email verification is already in production. You can copy/reuse this function: https://github.com/mfts/papermark/blob/77699f3404c538a25e4450f9d94bc933378cbb9c/pages/api/links/%5Bid%5D/verify-email.ts

Feb 29 '24 11:02 mfts

However, regarding email-authcode I wanted ask @mfts that since email-verification to view document feature is for pro-users. Do we want to that for datarooms as well? If yes, can you please finalize that email-verification PR #197.

The email verification is already in production. You can copy/reuse this function: https://github.com/mfts/papermark/blob/77699f3404c538a25e4450f9d94bc933378cbb9c/pages/api/links/%5Bid%5D/verify-email.ts

@Aashish-Upadhyay-101, @mfts All set ready for review

Mar 01 '24 06:03 digant2482

@mfts looks good to me. I have reviewed the entire PR.

I would like @mfts to also go through this PR briefly ; ) and let me know !

Mar 01 '24 08:03 Aashish-Upadhyay-101