papermark icon indicating copy to clipboard operation
papermark copied to clipboard

Feat/dataroom

Open digant2482 opened this issue 2 years ago • 10 comments

#69 . Review required

digant2482 avatar Nov 25 '23 18:11 digant2482

@digant2482 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 25 '23 18:11 vercel[bot]

Thanks @digant2482. Could you consolidate the schema migrations into one and resolve the merge conflicts.

It looks really good so far. I'm keen to add this to launch week 🚀

mfts avatar Dec 01 '23 04:12 mfts

@digant2482 also please Pull in latest changes and resolve the conflicts : )

Aashish-Upadhyay-101 avatar Dec 02 '23 15:12 Aashish-Upadhyay-101

@digant2482 also you should scope Data Room by Team

Aashish-Upadhyay-101 avatar Dec 02 '23 15:12 Aashish-Upadhyay-101

@digant2482 could you just create single migration for the data-room feature? I mean you created around 15 migrations. I would recommend you to just do a single migration.

Done

digant2482 avatar Dec 02 '23 19:12 digant2482

@digant2482 also you should scope Data Room by Team

On it!!!

digant2482 avatar Dec 02 '23 20:12 digant2482

Ready for review !!! 🚀

digant2482 avatar Dec 03 '23 13:12 digant2482

Hey @digant2482 i think having two versions of a dataroom will be confusing for many users, especially since we have none right now.

I would suggest going with the linktree style for now and tabling the hierarchical dataroom for a future time

mfts avatar Dec 21 '23 01:12 mfts

@mfts. On it

digant2482 avatar Dec 21 '23 13:12 digant2482

@digant2482 any updates? please respond, otherwise I will have to stab in and complete this feature ; )

Aashish-Upadhyay-101 avatar Jan 02 '24 13:01 Aashish-Upadhyay-101