mfts
fix: pass theme option as url params
fixes #791
Summary of changes: passed mode as the url param in the notion link and update the darkMode value in Notion doc
@DeepaPrasanna is attempting to deploy a commit to the mftsio Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
![oss-gg[bot] avatar](https://avatars.githubusercontent.com/in/835270?v=4 "Published by a pub.dev verified publisher"){kind=small}
I am really sorry for the delay. I will update within few hours.
No rush. I know you are also busy with other things. But great to keep this PR moving along.
I am really sorry for the delay. I will update within few hours.
No rush. I know you are also busy with other things. But great to keep this PR moving along.
@mfts Thank you for your patience :) I have taken into account your reviews and updated the code.
Pls also refer to the screen recording showing the changes.
Also, I think this may require updating docs so that users may know to send the query params for dark mode while uploading. https://www.loom.com/share/74ed5f801a8f476fa182eb0468ff1557?sid=3de9bb42-8b69-4fa0-940e-f1ae5dd9f6a4
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| papermark | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 26, 2024 10:37am |
@DeepaPrasanna
Another cool idea would be to just make a button on the Notion document, that toggles dark/light mode and when toggled it changes the Notion url by appending / removing the ?mode=dark url query param.
Perhaps a task for a new PR before ossgg ends?
@DeepaPrasanna Another cool idea would be to just make a button on the Notion document, that toggles dark/light mode and when toggled it changes the Notion url by appending / removing the
?mode=darkurl query param.Perhaps a task for a new PR before ossgg ends?
It seems a cool one! Am I correct in assuming that you are here referring to the document shown when hitting the papermark link? If yes, it gives the user handle theme too, which will be enhancing ux
Awarding DeepaPrasanna: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/DeepaPrasanna