papermark icon indicating copy to clipboard operation
papermark copied to clipboard

feat: logic for archiving dataroom

Open Khaan25 opened this issue 1 year ago • 21 comments

This PR fixes: #785

I've included a boolean in the function to archive a dataroom.

Will discuss some key points with @mfts and finish this feature.

Khaan25 avatar Oct 16 '24 06:10 Khaan25

@Khaan25 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 16 '24 06:10 vercel[bot]

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

github-actions[bot] avatar Oct 16 '24 06:10 github-actions[bot]

@Khaan25 looks good so far

  • missing a field on Dataroom table for isArchived
  • also missing the tab for the archived datarooms

mfts avatar Oct 16 '24 11:10 mfts

Yes, I'm gonna work on it

Khaan25 avatar Oct 17 '24 07:10 Khaan25

Hey, In the Link table, we've isArchived field, is that for any other usecase?

Khaan25 avatar Oct 17 '24 15:10 Khaan25

image

Here's a video: https://streamable.com/0yl2ym

Could not upload more than 10 MBs of video on GitHub :) FYI, Video link expires after 2 days :)

Khaan25 avatar Oct 17 '24 16:10 Khaan25

Just a quick question, image

You can see the image above, if we're on trial and we create dataroom then the trial-banner day isn't showing because it's fetching from the first data-room tab in the image, how about we proceed?

My initial thoughts are, query for first tab, if null then query for second tab, that way we won't have "days left" but "X days left"

What do you say?

Khaan25 avatar Oct 17 '24 16:10 Khaan25

@Khaan25

My initial thoughts are, query for first tab, if null then query for second tab, that way we won't have "days left" but "X days left"

Don't worry about that trial banner. it's a minor thing

mfts avatar Oct 20 '24 13:10 mfts

Alright. So we should mark this issue as complete?

Khaan25 avatar Oct 20 '24 13:10 Khaan25

@Khaan25 please sign the CLA as indicated above

mfts avatar Oct 21 '24 06:10 mfts

/recheck

Khaan25 avatar Oct 21 '24 06:10 Khaan25

recheck

Khaan25 avatar Oct 21 '24 06:10 Khaan25

I have read the CLA Document and I hereby sign the CLA

Khaan25 avatar Oct 21 '24 06:10 Khaan25

@mfts I've signed it

Khaan25 avatar Oct 21 '24 06:10 Khaan25

Sure, I'll do it and let you know

Khaan25 avatar Oct 22 '24 07:10 Khaan25

@mfts I've pushed the changes, can you please review?

Khaan25 avatar Oct 22 '24 08:10 Khaan25

@Khaan25 looks good. I will make some small changes today and then push it

mfts avatar Oct 22 '24 09:10 mfts

Cool

Khaan25 avatar Oct 22 '24 09:10 Khaan25

@mfts, Could you please review and give points? :)

Khaan25 avatar Oct 27 '24 05:10 Khaan25

/award 200

still requires changes from my end

mfts avatar Oct 31 '24 04:10 mfts

Awarding Khaan25: 200 points 🕹️ Well done! Check out your new contribution on oss.gg/Khaan25

oss-gg[bot] avatar Oct 31 '24 04:10 oss-gg[bot]