feat: logic for archiving dataroom
This PR fixes: #785
I've included a boolean in the function to archive a dataroom.
Will discuss some key points with @mfts and finish this feature.
@Khaan25 is attempting to deploy a commit to the mftsio Team on Vercel.
A member of the Team first needs to authorize it.
All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.
@Khaan25 looks good so far
- missing a field on Dataroom table for
isArchived - also missing the tab for the archived datarooms
Yes, I'm gonna work on it
Hey, In the Link table, we've isArchived field, is that for any other usecase?
Here's a video: https://streamable.com/0yl2ym
Could not upload more than 10 MBs of video on GitHub :) FYI, Video link expires after 2 days :)
Just a quick question,
You can see the image above, if we're on trial and we create dataroom then the trial-banner day isn't showing because it's fetching from the first data-room tab in the image, how about we proceed?
My initial thoughts are, query for first tab, if null then query for second tab, that way we won't have "days left" but "X days left"
What do you say?
@Khaan25
My initial thoughts are, query for first tab, if null then query for second tab, that way we won't have "days left" but "X days left"
Don't worry about that trial banner. it's a minor thing
Alright. So we should mark this issue as complete?
@Khaan25 please sign the CLA as indicated above
/recheck
recheck
I have read the CLA Document and I hereby sign the CLA
@mfts I've signed it
Sure, I'll do it and let you know
@mfts I've pushed the changes, can you please review?
@Khaan25 looks good. I will make some small changes today and then push it
Cool
@mfts, Could you please review and give points? :)
/award 200
still requires changes from my end
Awarding Khaan25: 200 points 🕹️ Well done! Check out your new contribution on oss.gg/Khaan25