iF.SVNAdmin icon indicating copy to clipboard operation
iF.SVNAdmin copied to clipboard

The function checkPHPVersion has Error

Open HongKing opened this issue 7 years ago • 1 comments

in config.inc.php (version 1.6.2 ), if my php version is 7.1, this check will not pass.

// Check PHP version.
if (!checkPHPVersion("5.3")) {
  echo "Wrong PHP version. The minimum required version is: 5.3";
  exit(1);
}

so, i edit the checkPHPVersion function in global.util.php

function checkPHPVersion($minimumVersion)
{
  $phpVersion = phpversion();
  $phpVersionParts = explode(".", $phpVersion);
  $minVersionParts = explode(".", $minimumVersion);
  $minVersionPartsCount = count($minVersionParts);

  if ($minVersionPartsCount >= 1) {
    if ($phpVersionParts[0] > $minVersionParts[0]) {
      return true;
    } else if ($phpVersionParts[0] < $minVersionParts[0]) {
      return false;
    }
  }

  if ($minVersionPartsCount >= 2) {
    if ($phpVersionParts[1] > $minVersionParts[1]) {
      return true;
    } else if ($phpVersionParts[1] < $minVersionParts[1]) {
      return false;
    }
  }

  if ($minVersionPartsCount >= 3) {
    if ($phpVersionParts[2] > $minVersionParts[2]) {
      return true;
    } else if ($phpVersionParts[2] < $minVersionParts[2]) {
      return false;
    }
  }

  return false;
}

HongKing avatar Oct 08 '16 08:10 HongKing

I did the same!

renatofj avatar Jan 31 '20 16:01 renatofj