minitest-vcr icon indicating copy to clipboard operation
minitest-vcr copied to clipboard

Published 20 hours ago • verified publisher icon mfpiccolo

Fix bug with overriding #setup/#teardown on Minitest::Spec

Open Aryk opened this issue 7 years ago • 5 comments

Addresses #24.

Now other gems can extend the setup and teardown methods with their own modules.

Aryk avatar Jul 03 '17 19:07 Aryk

Coverage Status

Coverage remained the same at 85.149% when pulling debb44e10eead68b393167b1784a473121f1c562 on Aryk:master into c48549414813e46406aef85d29fb872d00f9fb94 on mfpiccolo:master.

coveralls avatar Jul 03 '17 19:07 coveralls

Coverage Status

Coverage remained the same at 85.149% when pulling 565f7fdb76d260b7bf6d1b4b5bff3fda48af55e0 on Aryk:master into c48549414813e46406aef85d29fb872d00f9fb94 on mfpiccolo:master.

coveralls avatar Jul 03 '17 19:07 coveralls

Coverage Status

Coverage remained the same at 85.149% when pulling 565f7fdb76d260b7bf6d1b4b5bff3fda48af55e0 on Aryk:master into c48549414813e46406aef85d29fb872d00f9fb94 on mfpiccolo:master.

coveralls avatar Jul 03 '17 19:07 coveralls

@mfpiccolo - Your CI I believe has been broken for 1.9.3. It has nothing to do with my changes.

Can you merge this in?

Aryk avatar Jul 03 '17 19:07 Aryk

Hey everyone -- I just got burned by this bug not being fixed on master. @Aryk 's awesome fix got me working again but would be awesome to merge this so other people don't suffer the same fate.

Anything I can do to help get this rolling?

agraves avatar Apr 30 '18 18:04 agraves