Replace deprecated ppx_core with ppxlib

Open Lupus opened this issue 6 years ago • 4 comments

This PR tries to fix issue #40.

Mar 31 '19 17:03 Lupus

This fix works for me.

Apr 09 '19 21:04 copy

I'm not able to upgrade to ocaml 4.08 with sqlexpr installed despite this patch. I'm not familiar with opam packaging or ppx but I'm under the impression the issue is that the dependencies in the .opam file(s) are not changed by this PR.

Nov 14 '19 15:11 adrien-n

Looking at this again, that comment from me is wrong. That being said, src/OMakefile is not updated by this PR and probably needs the same change.

And I think the opam issue is rather that opam keeps the same dependencies even though the pin should change them.

Nov 15 '19 13:11 adrien-n

OK, this was caused by opam itself and upgrading it from 2.0.0 to 2.0.5 fixed my issue.

edit: that and/or not pinning all the packages of the repo; sorry for the noise.

Nov 15 '19 14:11 adrien-n