Martin Ficzel

Results 162 comments of Martin Ficzel

@kitsunet https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Application.php#L194 returns 0 if all went fine and the composer application passes this trough. So this should be simple.

I am suspecting that the neos-base-distribution has a dependency problem on master: I get `Installing neos/flow (4.0.25): Loading from cache` which is a bit oldish and also ``` Package typo3/neos-nodetypes...

@kitsunet i think i understand the problem now. The solution here requires `neos/demo` without version constraint wich allows composer to make all sorts of decisions. As solution i suggest to...

@kitsunet a way to make this even more useful and clean be to move the InstallSitePackage.php to Neos\\Flow\\Composer\\InstallerScripts->PostCreateProjectCmd and use the path `extra.neos.create-project-packageOptions` from the main manifest for configuration. That...

@kitsunet i played with moving the post create project command to the composer scripts in flow: https://github.com/neos/flow-development-collection/pull/1852 what do you think about this solution.

@davidspiola there is an alternate implementation based on flow that I mentioned above that would be a much more generic solution but is also in need of feedback

I suggest to postpone this for now and aim to 5.2 for this feature

It seems a bit unelegant to add a special class where all other composer magic is usually done in Neos\Flow\Composer\InstallerScripts . I would really prefer a configurable solution via the...

I would like to eventually remove the Language Configuration from Neos.Demo ... that way it could coexist with other site packages without problems. In which case it could still be...

I also think this is not solved yet fully but am not sure we should keep this pr open as we will probably end up with a different solution anyways?