Michael F. Herbst
Michael F. Herbst
I think @thchr would not mind implementing the AtomsBase interface or assist in making some of the features directly accessible on AtomsBase structures. Certainly something worth investigating in my opinion!
Well currently AtomsBase is just being rolled out. I think what could be useful is to sort of "port" the existing functionality in Crystalline/Bravais to the whole AtomsBase ecosystem. I...
Lgtm modulo adding a test. Would it make sense to make this part of AtomsBaseTesting to test also in downstream codes?
> ...but that's also a little clunky to read. Not if you add line breaks? Also why are atomic symbols special. What if I want to supply the atomic numbers...
@rkurchin Super sorry. I completely forgot about this PR. I'll take another look later today.
Yes I would essentially duplicate the version from `Atom`, i.e. just pass in a list of Identifiers (type `AbstractVector{
On the other hand in light of #56 we might drop the properties, so perhaps let's wait for the discussion over there to conclude.
I am open to whatever. I have to dmit I'm also a little confused how much detail each of the printing functions are supposed to provide in julia. My rationale...
I agree. This is useless. We should only do the extensive printing for small cells. You can always manually call the visualise function if you want (which we should document...
@jameskermode many thanks for reaching out! What you are describing is more or less what I had in mind with [AtomIO.jl](https://github.com/mfherbst/AtomIO.jl), namely to collect (under a common interface, which integrates...