mark burdett
mark burdett
Having just a @deprecated annotation gets a thumbs up from me, as static analysis tools can easily pick up on these annotations and warn the developer. A deprecation could always...
It seems operations are broken out here if they match ["http", "db", "browser", "resource"] as per https://github.com/getsentry/sentry/blob/e24037645f84f5531e5a9ab5ab5851ae74cca9c6/src/sentry/projectoptions/defaults.py#L75 So as long as a PHP app records the spans for e.g. database...
> In the Symfony SDK we [used](https://github.com/getsentry/sentry-symfony/blob/cbd486cdf5b9d1933e0dad1c72a84269397ca931/src/Tracing/Doctrine/DBAL/TracingDriverConnection.php#L24) a different convention because we trace queries at an even deeper level by distinguishing the different phases that are involved (executing the statement,...
If "db" is the standard then I suppose it could even be db.sql.conn.prepare
btw, I noticed Sentry has some updated docs on span operations: https://develop.sentry.dev/sdk/performance/span-operations/
Oops sorry, I pasted the wrong message in the initial issue report.
What I wanted to file an issue about here is that even after I add the parameter and return type declarations, drupal-check still reports an issue - the array type...
Please review the PR @ #402 where we try to get the non-GNU version of patch working
@arcanumbridge I found some other issues mentioning non-GNU patch also being broken on macOS. I'm not sure if macOS uses "BSD" as `PHP_OS_FAMILY` or something else? If "BSD," then hopefully...
Realized I could just check the php source code :) Looks like macOS uses "Darwin" as the `PHP_OS_FAMILY`, so this PR won't help there. But, could we tweak the logic...