Markus Fasel comments

Results 16 comments of


                                            Markus Fasel

[EMCAL-788] EMCAL cell selection, on-the-fly calibration

@davidrohr As can be seen above it is pending in review from @jmyrcha. Currently the event display neither uses the bad channel map nor does it reject pileup via a...

[EMCAL-788] EMCAL cell selection, on-the-fly calibration

I don't fully understand the error message, since the option names match. The only issue I could imagine is an implicit cast issue due to the missing `f` in the...

[EMCAL-788] EMCAL cell selection, on-the-fly calibration

Hi @davidrohr, indeed my VSCode autoformat settings applied the cmake formatter when saving the file after changes. I manually unapplied now all the formatting changes in the CMakeLists.txt - now...

[EMCAL-788] EMCAL cell selection, on-the-fly calibration

@davidrohr , yes I think we should merge it. The requested review will probably never come :(

[FOCAL-78, FOCAL-84] First commit for the geometry helper class for the FOCAL detector

CI error unrelated

ARM: Bump hdf5, numpy, scipy, Keras/tf and pandas

@singiamtel As discussed in the other PR I am also in favour of bumping to newer versions of sklearn, numpy, pandas, tensorflow and Keras, I just did the minimal changes...