morph-trans icon indicating copy to clipboard operation
morph-trans copied to clipboard

Need for code to undergo changes

Open thak123 opened this issue 8 years ago • 3 comments

The dynet lib used in the code (previously known cnn ) has older references which needs to changed from cnn to dynet . I have spent nice 6 hours on figuring out the issue :'(. Got it working though,

Anyone facing issue change the train-sep-morph files cnn references to dynet

thak123 avatar Oct 27 '16 17:10 thak123

Hi Gaurish,

Thanks! If you were able to run the code with the modifications, I'll be happy to merge your code, if you can send a commit.

mfaruqui avatar Oct 28 '16 00:10 mfaruqui

Hi Mr Faruqui,

Will send the commit for merging. Give me some time . Need to figure out how this commit thing works .:D

thak123 avatar Oct 28 '16 15:10 thak123

Sorry Manaal what I thought was working initially is isnt the correct way. I had literally hacked in the changes to the code. Kindly please do the refactoring of the code and commit the changes as it is becoming more complex and more difficult to solve the issue with dynet library also previous cnn repo has undergone a lot of changes and the make file throws errors on compiling. I request you to please do the needful asap.

thak123 avatar Nov 20 '16 13:11 thak123