mezzio-router icon indicating copy to clipboard operation
mezzio-router copied to clipboard

Published 20 hours ago • verified publisher icon mezzio

`DuplicateRouteDetector` has no tests 😱

Open gsteel opened this issue 2 years ago • 2 comments

gsteel avatar Mar 29 '23 09:03 gsteel

Its indirectly tested via the RouteCollectorTest tho. https://github.com/mezzio/mezzio-router/commit/bb9bce25a998b66666e58c7924a2b5bdb63a2de5

Not saying it should be like this, just that it is kinda tested. But TBH, the whole class should have been @internal as I would not expect that this is a service we should provide without an interface.

boesing avatar Mar 29 '23 09:03 boesing

Yes, I since noticed the indirect tests - I ran coverage locally and it came out at 0% because of the #[CoversClass] on the collector test case. I'll add an issue to mark it as internal for 4.0.0

gsteel avatar Mar 29 '23 09:03 gsteel

Closed via #67

gsteel avatar Jul 18 '24 06:07 gsteel