JustEnoughItems icon indicating copy to clipboard operation
JustEnoughItems copied to clipboard

[Other]: JEI Fabric has remapping errors with IJeiFluidIngredient preventing it being used

Open AlphaMode opened this issue 1 year ago • 9 comments

Other

image As seen in the image the classes don't get remapped this is preventing me from implementing fluids in jei

AlphaMode avatar Jul 13 '22 23:07 AlphaMode

Thanks for the report! Can you show me your build.gradle setup? I'm curious how you are requiring JEI's API in gradle

mezz avatar Jul 14 '22 00:07 mezz

https://github.com/Alpha-s-Stuff/TinkersConstruct/blob/457f49f8de92e70107ff8915555d9b340f2f6f9c/build.gradle#L130 I copied the wiki from here https://github.com/mezz/JustEnoughItems/wiki/Getting-Started-%5BJEI-10-or-higher-for-Forge-or-Fabric%5D

AlphaMode avatar Jul 14 '22 01:07 AlphaMode

Thanks for the extra info! That looks correct to me. I will ask modmuss, a loom developer, for help.

@modmuss50 do you know if I am doing something wrong with the way I create the obfuscated jei-fabric-api jar, or if I am telling modders to use the wrong loom commands to include it in their project?

mezz avatar Jul 14 '22 04:07 mezz

Noticed this is only the case for the API jar. It's correct for the full jar.

TropheusJ avatar Jul 23 '22 01:07 TropheusJ

Hi, sorry I only just saw this. (Poking me on discord is a better way to get in contact)

Is the API jar a mod with a fabric.mod.json file? Loom only remaps deps that have a fabric.mod.json file. Deps without are left untouched.

modmuss50 avatar Jul 31 '22 18:07 modmuss50

The API jar is not its own mod, it's just a bunch of interface files. Should I declare it as its own mod?

mezz avatar Aug 05 '22 23:08 mezz

I am trying to use JEI in Quilt workspace. Same issue as above where JEI does not get the mc classes compiled correctly in JEI sources. However, if use the jar from curseforge instead by cursemaven, the source is now correct and I am able to extend IJeiFluidIngredient. Dunno if this may help with trying to figure out the cause

modCompileOnlyApi "curse.maven:jei-238222:3944625"
//modCompileOnlyApi "mezz.jei:jei-${libs.versions.jeimc.get()}-fabric:${libs.versions.jei.get()}"

Pic of JEI source from JEI maven: image Pic of JEI source from using CurseMaven to pull from CurseForge: image

TelepathicGrunt avatar Aug 23 '22 15:08 TelepathicGrunt

Think the Issue is still happening, even though it's been cold for some time. First Plugin creation step already has a problem. public net.minecraft.resources.ResourceLocation getPluginUid() It actually errors at the path before the Actual ResourceLocation class which doesn't exit in Fabric. build.gradle file: image gradle.properties image

pixar02 avatar Sep 27 '22 15:09 pixar02