JustEnoughItems icon indicating copy to clipboard operation
JustEnoughItems copied to clipboard

Inventory Tweaks Tree sorting 1.16

Open IMarvinTPA opened this issue 3 years ago • 4 comments

I hope this makes it in, but I would understand if it does not. If not, can you help me understand how to make an API that would register a new comparator? I don't think the ENum IngredientSortStage makes adding new ones easy.

IMarvinTPA avatar Jun 06 '21 04:06 IMarvinTPA

Isn't Inventory Tweaks discontinued (especially in 1.13+)? Wouldn't it be better to reuse sorting rules from one of the modern and still maintained mods instead, such as: Inventory Profiles (IMO the best one as it has client-side sorting), Inventory Sorter (made by cpw), Inventory Tweaks Renewed, etc.?

Eric-01 avatar Jun 06 '21 07:06 Eric-01

I'm in the middle of adding the tree sorting feature to Inventory Tweaks Renewed, but I need to spend a fair bit of time with the network syncing code and have made no attempt yet at that. The reason I keep adding some form of Inventory Tweaks sorting to JEI is that it is the easiest way to find a display that shows "all the things" and test out the sorter, identify what's missing and add it to the file.

IMarvinTPA avatar Jun 06 '21 12:06 IMarvinTPA

This should definitely be an API call and not all included in here. I can help with this later.

mezz avatar Jun 10 '21 00:06 mezz

@mezz Ok. I'll make a new pull request for just the sorting config bits. I think I'm almost done getting InventoryTweaksRenewed working properly.

IMarvinTPA avatar Jun 10 '21 02:06 IMarvinTPA