Markus Metz

Results 71 comments of Markus Metz

Have you checked https://trac.osgeo.org/grass/ticket/1710 and https://trac.osgeo.org/grass/ticket/1680 ?

> [...] I'm an older GRASS dev who had to take a break for several years. I'm still getting used to the new workflow and git. Great to have you...

Maybe the culprit is at https://github.com/OSGeo/grass/blob/master/raster/r.proj/r.proj.h#L15 `typedef FCELL block[BDIM][BDIM];` it should rather be `typedef FCELL block[BDIM * BDIM];` with according adjustments of the CVAL macro at https://github.com/OSGeo/grass/blob/master/raster/r.proj/r.proj.h#L75 and in https://github.com/OSGeo/grass/blob/master/raster/r.proj/readcell.c#L95...

The valgrind output was only mentioning uninitialized bytes which can be avoided with ``` diff --git a/raster/r.proj/readcell.c b/raster/r.proj/readcell.c index 7f2fb79ef..6956ee0a5 100644 --- a/raster/r.proj/readcell.c +++ b/raster/r.proj/readcell.c @@ -70,6 +70,7 @@ struct...

@neteler close without merging because old, outdated and suggesting changes that should be two separate PRs?

A related test for TGIS mapset access is failing. This needs to be fixed first before merging.

> A related test for TGIS mapset access is failing. This needs to be fixed first before merging. This will require a bit more effort because GRASS TGIS still expects...

Why exactly do you want to support `r.external -r` for TGIS? A missing or empty range file can cause all sorts of problems with other modules. Particularly with temporal modules,...

A particular [Lambert Conformal Conic](https://proj.org/operations/projections/lcc.html) projection depends on the standard latitude parallel(s) and the longitude of projection center: these determine for which area this projection is valid. Coordinates should not...

In [GRASS](https://github.com/OSGeo/grass/tree/master/lib/external/shapelib), we use a customized subset of shapelib which is only used to handle dbf files. Thus using C++ for the internals of shapelib does not immediately affect GRASS....