metrics
metrics copied to clipboard
metrics-rs
chore/hyper 1.1 upgrade
- update to hyper 1.1
- factor large
PrometheusBuilder.buildfunction into separate functions - move those functions into separate modules to reduce some of the feature driven uses
- add an http-listener integration test
My testing is limited. I did add the integration test and wanted to maybe expand it to be more robust.
Oh yeah, this is definitely a meaty one. :)
I would say that we should move the builder code into a new directory (builder) and split the push gateway code and HTTP listener code into their own files, otherwise it starts to get a little crowded.
Once that's sorted, and you've cleaned up some more of the leftover stuff (commented out code, print statements, etc) we can start talking through the actual changes.
Sounds like a plan. That's the direction I was going to go. Now to find some more time.
@tobz Took a shot at reorganizing the exporters. I removed the nested closures of the http exporter as some might find it easier to read. I need to revisit Cargo.toml.
@tobz Would you like me to rebase and --signoff on my stuff. It'll require a diverging force push.
@tobz Would you like me to rebase and --signoff on my stuff. It'll require a diverging force push.
If that's cool with you, that'd be nice. Force pushing is fine.
@evaneaston Just noticed the merge to get up-to-date with main.
I'll take a final pass shortly and hopefully get this merged today. I think it's close enough that it's good enough to merge, since there's a lot of other changes queued up for release and I'll likely be doing some stylistic cleanup to my own preferences anyways.