metricq-python icon indicating copy to clipboard operation
metricq-python copied to clipboard

remove `Aggregate.dict()`, `TimeValue.dict()`.

Open bmario opened this issue 2 years ago • 3 comments

This method is used in parsing HistoryResponse in the metricq-grafana endpoint for the timeline request. The active_time attribute would allow us to draw the last (or only) aggregate in the MetricQ-Webview.

bmario avatar Feb 19 '23 17:02 bmario

I'm not sure I even like the dict there at all. I mean sure we can add active_time. But in general it seems arbitrary whether to use mean, and/or sum, integral etc... Isn't that more consumer dependent? What's the advantage to have that decision encoded in the interface?

tilsche avatar Mar 02 '23 12:03 tilsche

Actually, we don't touch the dict in metricq-grafana, but pass that down as is to metricq-js. That was the whole point of the timeline endpoint/query there

bmario avatar Mar 02 '23 14:03 bmario

We discussed to deprecate / delete the dict function and do the conversion in metricq-grafana

tilsche avatar Mar 06 '23 16:03 tilsche