ring-swagger icon indicating copy to clipboard operation
ring-swagger copied to clipboard

WIP: Adds support for string to collection coercion based on collectionFormat

Open Deraen opened this issue 8 years ago • 4 comments

Fixes #69

TODO:

  • We currently use collectionFormat multi as default in other parts of code: https://github.com/metosin/ring-swagger/blob/master/src/ring/swagger/json_schema.clj#L56, per Swagger/OpenAPI spec csv should be the default
  • Coercion tests are broken, they use broken coercer function which returns matchers instead of coercer so they only run single layer of coercions instead of doing recursive coercion
  • Would be nicer to set collection-format instead of collectionFormat. Maybe json-schema should do key transformations so that snake-case can be used here?

Deraen avatar May 24 '16 18:05 Deraen

LGTM

ikitommi avatar May 24 '16 19:05 ikitommi

This should be merged?

ikitommi avatar Jun 23 '16 14:06 ikitommi

Only if the todo items are implemented.

Deraen avatar Jun 23 '16 18:06 Deraen

@Deraen Any plans to complete this? I'd be eager to use it. I guess the best alternative now is to spec the param to string and do parsing in the app?

ovan avatar Aug 25 '16 10:08 ovan