Initial implementation of json-schema import

[hkupty]

This allows a very basic json-schema->malli conversion.

Still missing for this PR

• [ ] cleanup TODOS;
• [ ] ensure function names are sane;
• [ ] ensure all json-schema features are supported (at least for one specific version, i.e. draft-7):
  • [x] Enum
  • [x] Const
  • [x] Annotation
  • [ ] Comments
  • [X] String
    • [x] Length
    • [x] Regular Expressions
    • [ ] Format
  • [X] Numeric Types
    • [X] Number
    • [X] Integer
    • [ ] Multiples
    • [ ] Range
  • [X] Object
    • [x] Properties
    • [x] Required
    • [x] Size
    • [ ] Dependencies
    • [ ] Pattern Properties
  • [x] Array
    • [x] Items (list)
    • [x] Items (tuple)
    • [ ] Length
    • [ ] Uniqueness
  • [x] Boolean
  • [x] Null
  • [x] Combining
    • [x] oneOf
    • [x] allOf
    • [x] anyOf
    • [x] not
  • [x] $ref

[ikitommi]

Looking forward to this. Related project: https://github.com/akovantsev/json-schema-to-clojure-spec

[hkupty]

Thanks for the reference, I'll take a look at it.

[hkupty]

@ikitommi I'm really sorry for taking so long to release the PR for review. I've unfortunately shifted priorities at my project (which was the main driver for this PR) and couldn't really invest time into finish. Found some time after holidays to tidy things up and I want to release this as soon as possible.

I'm intending to write some tests, but wanted to get a review going not to delay this any further.

Once again, sorry for having you waiting on this.

Happy new year, btw. Best regards, Henry

[hkupty]

I've decided to leave some stuff out for now, but I can implement if needed. Again, the idea was to get this rolling. Could be in a separate PR as well.

[hkupty]

@ikitommi revisting this now since it might be that I'll end up getting back to the project that inspired this PR. wdyt about this PR?

[tangrammer]

any update or review on this work? could i contribute to it too?

[hkupty]

It is unfortunate to have it dangling... I would really like to merge this, but it is unfair of me to push for it since I'm not even using clojure on my daily work anymore for quite some time now... Feel free to take over the patches here, @tangrammer. I wanted to get some feedback from the approach and merge something - even incomplete if the case - at least as a basis.

[tangrammer]

I'll try it 😅 , could you provide some data example to test the overall functionality?

[tangrammer]

@hkupty no worries just found the way!

(require '[clojure.walk :refer (keywordize-keys)])

(def data {"$id" "https://example.com/person.schema.json",
           "$schema" "https://json-schema.org/draft/2020-12/schema",
           "title" "Person",
           "type" "object",
           "properties"
           {"firstName"
            {"type" "string", "description" "The person's first name."},
            "lastName"
            {"type" "string", "description" "The person's last name."},
            "age"
            {"description"
             "Age in years which must be equal to or greater than zero.",
             "type" "integer",
             "minimum" 0}}})

(def my-schema (schema->malli (keywordize-keys data)))
(m/schema? my-schema)
(m/form my-schema)
(assert (= true (m/validate my-schema (keywordize-keys {"firstName" "John", "lastName" "Doe", "age" 21}))))

(assert (not= true (m/validate my-schema (keywordize-keys {"firstName" "John", "lastName" 1, "age" 21}))))

[vharmain]

It's really nice to see that this PR is alive again! We've had discussions with @bsless about bi-directional JSON-schema support on Clojurians Slack #malli channel. Welcome there to discuss @tangrammer

[PavlosMelissinos]

Great PR! It's missing some essential features though, e.g. the following syntax examples fail:

{"type": "string", "format": "uuid"} ;; this parses as string, should be `uuid?`

{"type": ["string", "null"]} ;; throws an exception and I'm not seeing it in the TODO list

I think I have fixed both (in my local copy) and I'll try to work further on this during the weekend if there's interest.

I'd like to know what is missing from this in order to be merged. Would adding some round-trip unit tests (malli->json-schema->malli) to achieve parity with malli.json-schema-test suffice or would you prefer dedicated tests?

[PavlosMelissinos]

I'll try to work further on this during the weekend

I have pushed the results to a branch on my fork. You can check out the ground truth here for a list of conversions that work.

Should I create a new PR or...?

Would adding some round-trip unit tests (malli->json-schema->malli) to achieve parity with malli.json-schema-test suffice

FYI unfortunately round trip tests don't work because some syntax on both sides is ambiguous

[spieden]

Could be a handy use case for generative testing. i.e. Generate data and verify that it validates both against a json schema directly (using a separate library) and against its malli representation. Really slick would be a function from a particular json schema to a generator. The generator could emit both valid and subtly invalid data and you could just check that the two validation paths agree.

[bsless]

Is this PR still active?

[vharmain]

Is this PR still active?

This ticket is on our "Open source backlog" in "Waiting" status but I'm not absolutely sure what it's waiting for. Anyway I think this is still on our radar but not on top of the backlog.

[PavlosMelissinos]

I'm not absolutely sure what it's waiting for

This PR is missing some stuff (e.g. it doesn't have any tests and some conversions just don't work).

I spent some time on it a couple months ago and while there are still some nuances because the conversions are lossy (e.g. after a round trip you aren't guaranteed to get the initial result), I think it's an improvement.

If there's interest I could raise a new PR but it will need feedback before it can be reviewed by metosin and hopefully merged.

Here's the diff in case anyone wants to play with it.

[spieden]

I tried it out on a complex schema with a graph of $refs and it encountered the problem of schemas in :definitions referring to one another. Will need to reduce over a topological sort and pass along a registry map I guess. 🤔

[spieden]

Unless, is there some way to do late binding?

[PavlosMelissinos]

@spieden Do you have a small repro & expected result? I'll try to work on it during the weekend.

[timothypratley]

@PavlosMelissinos Thank you for running with this, I think this would be a very useful feature.

I've been trying to do json-schema validation in this tiny example: https://github.com/timothypratley/vegamite I checked out your branch in a parallel directory and used a :local/root dependency to it to get your code.

Sadly, it throws a :malli.core/invalid-schema and it's not clear to me why. Any suggestions?

I'm trying to use the vega-lite schema which is very large. I'm hoping that by converting to a Malli schema, it will produce nice error messages if I miss-spell a field etc.

[PavlosMelissinos]

@timothypratley I'll try to take a look later today (but I can't promise I will manage to). However, the example you're using is huge and my version of the converter still has some known problems (e.g. with refs). In the meantime, I've opened a new (draft) PR to keep discussions clean; do you think you can try to come up with a smaller repro and add a comment there?

[zcaudate]

I'm wondering if this is relatively stable. would like to try it out.

[PavlosMelissinos]

@zcaudate Sadly I haven't managed to work on this since my last comment. Feel free to try it out but the problems that @timothypratley has pointed out here and in the other PR are still there. Depending on your use cases you might be able to get some value out of it but I wouldn't call it stable...