Eric Liu
Eric Liu
Refactor to use the shorthand for subscription syntax to avoid manually unsubscribing in the `onMount` return function.
A recent fix to the upstream Carbon library caught my eye: https://github.com/carbon-design-system/carbon/pull/13069 It disables the "resize" attribute for `TextArea` if the `cols` prop is specified. The differences in behavior compared...
This was flagged in https://github.com/carbon-design-system/carbon-icons-svelte/pull/158#pullrequestreview-1314834820 The current `build-info.json` generated by [index.ts](https://github.com/carbon-design-system/carbon-icons-svelte/blob/master/src/index.ts#L82) is used by the documentation site. The impact of this bug is that the documentation site for icons may...
Ref: https://github.com/carbon-design-system/carbon-components-svelte/pull/1636#issuecomment-1400680058 Currently, the `getSvelteEntry` relies purely on `package.json` for the Svelte entry point. It will throw an error if the `"svelte"` field is absent in the root `package.json`. The...
This PR is based on #816. - Ugprades `sveld` to v0.20 to use generics - Uses generics to type `DataTable` so that types for `rows` and `headers` can be inferred...
There's a subtle, rather significant, UX difference between the two. The event should fire on keydown and not on the keyup event. E.g., ```js if ( document.activeElement instanceof HTMLInputElement ||...
With unit tests in place, we can more confidently refactor the code to TypeScript. In addition to greater type safety, this would conserve the manual effort of syncing type definitions....
It would be nice to have a function (provided through the `let:` directive or as an accessor) to programmatically update the theme. This way, the consumer wouldn't need to maintain...
It would be nice for the theme class to be toggled by the component instead of manually doing so.
Thank you for the resource. I agree that font weights should not change if they impact layout shift. Could an exception be made for fixed-width fonts?