Eric Liu

Results 252 comments of Eric Liu

Commenting for posterity. This library was rewritten in v0.11, but many concepts still apply. ## optimizeImports preprocessor `optimizeImports` does not perform preprocessing. Additional preprocessing (e.g., TypeScript) should be performed first....

This is a very belated reply. A lot has changed since this library was first released (SvelteKit was

Closing – Svelte preprocessors only run on Svelte files. Although the use case is valid, I believe this to be out of scope of the library for now.

I rewrote this library from scratch in [v0.11.0](https://github.com/carbon-design-system/carbon-preprocess-svelte/releases/tag/v0.11.0), specifically focusing on getting the `optimizeCss` plugin to a good state. `optimizeCss` is now a plain Vite plugin, meaning it should work...

Can you attach a screenshot instead of linking to a separate site?

Linking this: https://github.com/carbon-design-system/carbon-components-svelte/discussions/1420

I agree that we should only forward useful events. A lot of components have a wrapping `div` in which many events are forwarded to. We should not forward events in...

@theetrain agree - skeleton variants should live as standalone components. We should remove the skeleton prop.

Personally, I echo @SimpleProgrammingAU's sentiment. - `$$restProps` is discouraged because it's difficult to statically analyze/optimize. - Predictable API: is `$$restProps` forwarded to the "top-level" element or the "most important" element...