Eric Liu

Results 252 comments of Eric Liu

In addition to passing the CI/deploy preview, could you remove the committed `package-lock.json` files?

How about creating separate PRs that address the issues individually? - DataTableSkeleton #423 - new SelectableTileGroup component #428 - new RadioTileGroup component

> BTW, you said in the issue comments to use `selectedItem` `selectedItems` which also is breaking? Wasn't sure if you realised? `selectedValue` and `selectedValues` would be new props if `SelectableTileGroup`...

For testing locally, you can use the doc website as a UI. Refer to CONTRIBUTING.md: https://github.com/IBM/carbon-components-svelte/blob/master/CONTRIBUTING.md#documentation-set-up

> i haven't removed RadioTileGroup yet - I'm fighting to keep it - everything is still backwards compatible? Save it for another PR

Are you able to get two way binding on `selectedValues` to work? ```svelte let selectedValues = ["1"] Option 1 Option 2 Option 3 ```

@ispyinternet take a look at this: https://svelte.dev/repl/bf4a1ebbe12b49d38f0fcd15ca782a04?version=3.30.1 It supports three use cases using component composition: ## 1) Binding w/ a single prop The initial selected items are in `sel`. ```svelte...

@ispyinternet Does it fulfill the three test cases mentioned above? 1) bind w/ a single prop 2) bind w/ a single prop with initially selected children 3) "controlled"

@ispyinternet I added an example that tests the three use cases: https://carbon-components-svelte-onddzi298.vercel.app/framed/SelectableTile/SelectableTileReactive Click around in the first two. The bound `selectedValues` is indeed updating correctly by clicking tiles. However, I'm...

@ispyinternet Perhaps I was unclear. Take the Svelte REPL as a direct reference. > That is, we can either supply an array of scalars, or an array of { value,...