rose icon indicating copy to clipboard operation
rose copied to clipboard

Update Rose Tutorial to use Canned Amazon Data

Open wxtim opened this issue 2 months ago • 2 comments

Update tutorials after https://github.com/cylc/cylc-flow/pull/7044, changing rainfall data source to Amazon.

N.b. https://github.com/cylc/cylc-flow/pull/7044 and subsequently the update tutorials Workflow will be required prior to this passing automated tests.

To test locally cp -r ~/cylc-flow/cylc/flow/etc/tutorial/cylc-forecast-workflow ~/rose/metomi/rose/etc/tutorial/rose-suite-tutorial and follow the tutorials at https://metomi.github.io/rose/doc/html/tutorial/rose/suites.html#rose-suite-configurations.

wxtim avatar Nov 05 '25 14:11 wxtim

Does the Rose tutorial now require the new HDF library thinggy?

oliver-sanders avatar Nov 05 '25 14:11 oliver-sanders

Does the Rose tutorial now require the new HDF library thinggy?

Unclear - the only tutorial involving this new data which is ever going to work without Cylc/Cylc-Rose being installed is the rose task-run -O test tutorial, and that uses the data after it has been extracted to CSV.

I think that there is an implicit assumption that cylc-flow[tutorial] has been installed. Is there a reason that we haven't made this assumption explicit? Is there a risk of creating circular dependencies?

wxtim avatar Nov 06 '25 10:11 wxtim

I think that there is an implicit assumption that cylc-flow[tutorial] has been installed. Is there a reason that we haven't made this assumption explicit? Is there a risk of creating circular dependencies?

We would have to create an optional dependency to do this:

$ pip install metomi-rose[tutorial]

Where metomi-rose[tutorial] would depend on cylc-flow[tutorial].

oliver-sanders avatar Nov 24 '25 16:11 oliver-sanders

I think that the tests are failing because I've lower-pinned Cylc to 8.6.1 - hopefully they'll pass once we've released that.

wxtim avatar Nov 27 '25 10:11 wxtim

$ rose tutorial
rose tutorial SUITE [DIR]

Available tutorial suites:
api-keys
cylc-forecasting-workflow
failif-warnif
forecast-script
map-template
metadata-tutorial
rose-stem
rose-suite-tutorial
rose-weather-forecasting-suite
test-data
widget

$ rose tutorial api-keys
Tutorial 'api-keys' does not exist

oliver-sanders avatar Nov 27 '25 11:11 oliver-sanders

$ rose tutorial rose-weather-forecasting-suite
..

$ cylc play rose-weather-forecasting-suite -N
...
ERROR - [20251127T1000Z/get_rainfall/01:running] failed/ERR
...

$ cylc cat rose-weather-forecasting-suite//20251127T1000Z/get_rainfall/01 -f e
Traceback (most recent call last):
  File "~/cylc-run/rose-weather-forecasting-suite/bin/get-rainfall", line 220, in <module>
    main()
  File "~/cylc-run/rose-weather-forecasting-suite/bin/get-rainfall", line 213, in main
    data = process_rainfall_data(canned_data, resolution, domain)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "~/cylc-run/rose-weather-forecasting-suite/bin/get-rainfall", line 186, in process_rainfall_data
    rainfall.add(lng, lat, val)
  File "~/cylc-run/rose-weather-forecasting-suite/bin/get-rainfall", line 89, in add
    self.data[itt_y][itt_x].append(self.value_map(value))
    ~~~~~~~~~~~~~~~~^^^^^^^
IndexError: list index out of range

oliver-sanders avatar Nov 27 '25 11:11 oliver-sanders

@oliver-sanders - comments https://github.com/metomi/rose/pull/2959#issuecomment-3585386241 and https://github.com/metomi/rose/pull/2959#issuecomment-3585399278 responded to with https://github.com/metomi/rose/pull/2959/commits/549a6d3444b8b7ce67bafa6d22cbfac60c0e5a48.

wxtim avatar Nov 27 '25 14:11 wxtim