rose icon indicating copy to clipboard operation
rose copied to clipboard

Test Hole: No test failing for line 180 of date.py when a change should have caused a test failure.

Open wxtim opened this issue 3 years ago • 1 comments

In https://github.com/metomi/isodatetime/pull/165/files we changed the name of two functions used by Rose, but only one test seems to fail as a result of the changes:

  • set_time_zone_to_local becoming to_local_time_zone
  • set_time_zone_to_utc becoming to_utc

Apparently failing because of change of name of set_time_zone_to_local.

However the occurrence of set_time_zone_to_utc at line 180 of metomi/rose/date.py doesn't cause any tests to fail - we should probably make sure that this code is covered by tests.

wxtim avatar Apr 10 '22 08:04 wxtim

(Now on L182) https://github.com/metomi/rose/blob/78e730522a488f471beaec0526fa7fbfab6f81f7/metomi/rose/date.py#L181-L182

MetRonnie avatar Apr 28 '22 11:04 MetRonnie