Update testdata-minimal scripts
close #604
Codecov Report
Merging #691 (513cf53) into main-dev (c419649) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## main-dev #691 +/- ##
=========================================
Coverage 80.04% 80.04%
=========================================
Files 97 97
Lines 17422 17422
=========================================
Hits 13946 13946
Misses 3476 3476
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 80.04% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Hi @jgriesfeller
I would like some feedback hare. Specially regarding on the scope of the PR.
I think that I could push a bit further and combine all the scripts into one CLI app, that creates all the files required and put them into date stamped tar file. What do you think?
@jgriesfeller
It looks to me that scripts/testdata-minimal/TM5_subset.sh is not used when creating the test dataset.
It is supposed to be run on the test files directly, so I do not know where the original files are located.
Can you think of any way to check if it was used on the test files?
These were just some quick and dirty creation scripts for the testdata-minimal. I moved them into the repo after some problems to find them after EBAS had changed its data format some months back. They have been part of the testdata-minimal tar file before. So I think they should be in the repo, but we should not spent a great amount of time on them. So I am fine with the current structure. But I will also support if you decide to do them right.
These were just some quick and dirty creation scripts for the testdata-minimal. I moved them into the repo after some problems to find them after EBAS had changed its data format some months back. They have been part of the testdata-minimal tar file before. So I think they should be in the repo, but we should not spent a great amount of time on them. So I am fine with the current structure. But I will also support if you decide to do them right.
I'll add usage instructions to the README before merging
I'm going to spend a bit of time over the next week cleaning up and testing the scripts.