pyaerocom icon indicating copy to clipboard operation
pyaerocom copied to clipboard

Improve ColocatedData.to_dataframe() method

Open thorbjoernl opened this issue 1 year ago • 1 comments

Change Summary

I found the current implementation of ColocatedData.to_dataframe() lacking so I expanded it a bit.

Produced data frames will now include:

  • Time
  • Station name
  • Data source (obs/mod)
  • Latitude
  • Longitude
  • Altitude
  • Variable value (obs/mod)

Related issue number

Checklist

  • [x] Start with a draft-PR
  • [x] The PR title is a good summary of the changes
  • [ ] PR is set to AeroTools and a tentative milestone
  • [x] Documentation reflects the changes where applicable
  • [ ] Tests for the changes exist where applicable
  • [ ] Tests pass locally
  • [ ] Tests pass on CI
  • [ ] At least 1 reviewer is selected
  • [ ] Make PR ready to review

thorbjoernl avatar Oct 08 '24 14:10 thorbjoernl

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.87%. Comparing base (f0acbf6) to head (23809dc). Report is 326 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/colocation/colocated_data.py 75.00% 5 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1369      +/-   ##
============================================
+ Coverage     78.85%   78.87%   +0.01%     
============================================
  Files           136      136              
  Lines         20849    20863      +14     
============================================
+ Hits          16441    16455      +14     
  Misses         4408     4408              
Flag Coverage Δ
unittests 78.87% <75.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 08 '24 14:10 codecov[bot]