One way to change freq for map processing
Change Summary
Made it so when ModelMapsEngine is run, main_freq is changed to maps_freq. If maps_freq=coarsest, then the coarsest freq of the given freqs are chosen
Related issue number
Proposed fix to #1260
Checklist
- [ ] Start with a draft-PR
- [ ] The PR title is a good summary of the changes
- [ ] PR is set to AeroTools and a tentative milestone
- [ ] Documentation reflects the changes where applicable
- [ ] Tests for the changes exist where applicable
- [ ] Tests pass locally
- [ ] Tests pass on CI
- [ ] At least 1 reviewer is selected
- [ ] Make PR ready to review
Codecov Report
Attention: Patch coverage is 79.10448% with 14 lines in your changes missing coverage. Please review.
Project coverage is 78.84%. Comparing base (
af3a797) to head (85aee2e). Report is 339 commits behind head on main-dev.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pyaerocom/aeroval/modelmaps_engine.py | 78.46% | 14 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main-dev #1312 +/- ##
============================================
- Coverage 78.84% 78.84% -0.01%
============================================
Files 136 136
Lines 20790 20856 +66
============================================
+ Hits 16392 16444 +52
- Misses 4398 4412 +14
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 78.84% <79.10%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good. Only minor changes. I would opt for
model_datanotmodeldatabecause the former is more readable and modeldata isn't an English word. I like the_get_maps_freqfunction. We should use that in the overlay maps as well. If you haven't please merge with a recent version ofmain-devas well.
Agreed. I've changed the name.
I have merged it in now. The overlay map now uses both _get_maps_freq and the new model reading method. Could you have a look over the new changes? The merging was quite messy, but I think I manged to put everything in the right order