pyaerocom icon indicating copy to clipboard operation
pyaerocom copied to clipboard

O3 mda8

Open thorbjoernl opened this issue 1 year ago • 1 comments

Change Summary

Related issue number

fix #863

Checklist

  • [x] Start with a draft-PR
  • [ ] The PR title is a good summary of the changes
  • [ ] PR is set to AeroTools and a tentative milestone
  • [ ] Documentation reflects the changes where applicable
  • [ ] Tests for the changes exist where applicable
  • [ ] Tests pass locally
  • [ ] Tests pass on CI
  • [ ] At least 1 reviewer is selected
  • [ ] Make PR ready to review

thorbjoernl avatar May 08 '24 15:05 thorbjoernl

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.76%. Comparing base (af621d8) to head (d718577). Report is 1 commits behind head on main-dev.

:exclamation: Current head d718577 differs from pull request most recent head e74e6d3

Please upload reports for the commit e74e6d3 to get more accurate results.

Files Patch % Lines
pyaerocom/io/mscw_ctm/additional_variables.py 92.85% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1165      +/-   ##
============================================
- Coverage     79.25%   78.76%   -0.50%     
============================================
  Files           129      127       -2     
  Lines         20220    20120     -100     
============================================
- Hits          16025    15847     -178     
- Misses         4195     4273      +78     
Flag Coverage Δ
unittests 78.76% <93.33%> (-0.50%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 08 '24 15:05 codecov[bot]

Idea: O3 and CO both need MDA8. Therefore maybe making an operator which takes a ColocatedData object and applies for example a daily maximum of the 8 hourly mean (MDA8) could be useful. Would need to be specified in a config, and then dealt with here (similar to how we use use_fairmode): https://github.com/metno/pyaerocom/blob/63ca935cdea19c73ff45d960d9a91c46a384a720/pyaerocom/aeroval/coldatatojson_engine.py#L120

lewisblake avatar Jun 17 '24 09:06 lewisblake

Want a way to keep both the original timeseries and the MDA8. Expand ColocatedDataList?

lewisblake avatar Jun 24 '24 09:06 lewisblake

Working on a new branch so closing this PR. New PR: https://github.com/metno/pyaerocom/pull/1224

thorbjoernl avatar Jun 24 '24 11:06 thorbjoernl