pyaerocom icon indicating copy to clipboard operation
pyaerocom copied to clipboard
verified publisher icon metno

Fix obs climatology

Open Ovewh opened this issue 1 year ago • 2 comments

Change Summary

Rather than having a opaque boolean toggle to enable climatology calculation. Which does not really tell what "climatology" means in pyaerocom. To figure that out you need to look at the const. The changes i suggest it to replace the keyword obs_use_climatology with a dictionary. Where the start stop, data coverage filters and which "year" the climatology should be set can be specified.

Related issue number

fix #1125

Checklist

  • [x] Start with a draft-PR
  • [x] The PR title is a good summary of the changes
  • [ ] PR is set to AeroTools and a tentative milestone
  • [ ] Documentation reflects the changes where applicable
  • [ ] Tests for the changes exist where applicable
  • [ ] Tests pass locally
  • [ ] Tests pass on CI
  • [ ] At least 1 reviewer is selected
  • [ ] Make PR ready to review

Ovewh avatar Apr 23 '24 11:04 Ovewh

@Ovewh are you still working on this? Would you like some help? It seems like a nice bit of work which could be useful

lewisblake avatar May 27 '24 09:05 lewisblake

Yea it would be nice with some help... There where more changes required than I envisioned.

Ovewh avatar May 27 '24 09:05 Ovewh