pyaerocom icon indicating copy to clipboard operation
pyaerocom copied to clipboard

Readpyaro extension

Open dulte opened this issue 1 year ago • 3 comments

Adds possibility for extra fields from pyaro.

Is dependent on PRs #1115 and #1102, so they should be merged before this PR

Related issue number

fix #1118

Checklist

  • [x] Start with a draft-PR
  • [x] The PR title is a good summary of the changes
  • [x] PR is set to AeroTools and a tentative milestone
  • [x] Documentation reflects the changes where applicable
  • [x] Tests for the changes exist where applicable
  • [x] Tests pass locally
  • [x] Tests pass on CI
  • [x] At least 1 reviewer is selected
  • [x] Make PR ready to review
  • [x] Merge #1102
  • [x] Merge #1115

dulte avatar Apr 16 '24 14:04 dulte

Tests will fail until https://github.com/metno/pyaro/pull/25 is merged with the pyaro main dev

dulte avatar Apr 16 '24 14:04 dulte

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.78%. Comparing base (5485b4a) to head (9b4acd6). Report is 629 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1124      +/-   ##
============================================
+ Coverage     78.75%   78.78%   +0.03%     
============================================
  Files           127      127              
  Lines         20105    20101       -4     
============================================
+ Hits          15833    15836       +3     
+ Misses         4272     4265       -7     
Flag Coverage Δ
unittests 78.78% <100.00%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 16 '24 15:04 codecov[bot]

I took the liberty to finish this up since @dulte is quite busy right now (I need it for some other work). @dulte I'll leave this until tommorrow afternoon in case you want to have a look.

jgriesfeller avatar May 13 '24 12:05 jgriesfeller