Add pages argument to WebDisplayOpts class
Closes #965. Based on the requirements presented there, a default it set to ["maps", "evaluation", "intercomp", "overall", "infos"]. If this default is overridden by providing a pages argument, all the pages which are intended to show up on the web must be provided.
Codecov Report
Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
Project coverage is 78.82%. Comparing base (
0c8316f) to head (6189c5b). Report is 589 commits behind head on main-dev.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pyaerocom/aeroval/experiment_processor.py | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main-dev #1025 +/- ##
=========================================
Coverage 78.82% 78.82%
=========================================
Files 128 128
Lines 20209 20209
=========================================
Hits 15930 15930
Misses 4279 4279
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 78.82% <50.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good. I juste have to implement the logic on the frontend. From which pyaerocom version should I expect this new format?
Also, one current user of this feature is CAMS2_2 that adds reports page. So, it should be explained, to people running those experiments, how they need to modify their config files.
Looks good. I juste have to implement the logic on the frontend. From which pyaerocom version should I expect this new format?
Great. >v0.16.0 should have this feature implemented.
Also, one current user of this feature is CAMS2_2 that adds reports page. So, it should be explained, to people running those experiments, how they need to modify their config files.
I will speak to @andagit about how to modify her config files.
Can you approve this, @AugustinMortier if you are okay with it? Thanks.
@AugustinMortier will the website be able to handle this before the next release (Tuesday 9.4.24)? Some attention now needs to be given to this PR since there are conflicts
It will be ready for the release after, I think. We need to finalize the deployment of the API version of AeroVal on the main server first.
On Sun, Apr 7, 2024, 16:05 Lewis Blake @.***> wrote:
@AugustinMortier https://github.com/AugustinMortier will the website be able to handle this before the next release (Tuesday 9.4.24)? Some attention now needs to be given to this PR since there are conflicts
— Reply to this email directly, view it on GitHub https://github.com/metno/pyaerocom/pull/1025#issuecomment-2041481956, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEVTXGVSZXN6K6PX6S4YPKDY4FHDVAVCNFSM6AAAAABELDPJEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGQ4DCOJVGY . You are receiving this because you were mentioned.Message ID: @.***>
@AugustinMortier Any updates on this?
Not yet, sorry. Busy with other projects and initiating the API documentation. I'll try to have a look next week!
The front end now supports the pages option.
Working example here
It would probably make sense to "connect" a little the list of pages in the config file to the actual pyaerocom computation: e.g, if the contour plots have not been processed, but the 'maps' page is in the list of visible pages, the user should have at least a warning (so we avoid ending up with empty pages)..?