metlo icon indicating copy to clipboard operation
metlo copied to clipboard

Param detection in request paths

Open ZeRego opened this issue 2 years ago • 1 comments

How does Metlo detect params?

Some request paths are marked with incorrect parameters.

The current path in Metlo: /api/{param1}/org/{param2} Expected /api/{param1}/org/onboardingStatus

Route source: https://github.com/lightdash/lightdash/blob/e6057c27c37659235e1617527e8a6e27881ee9bc/packages/backend/src/routers/organizationRouter.ts#L176

Could it use the express routes to detect the params instead of using some magic logic? It can even detect what is the name of the param instead of using generic param1 param2 etc eg: /user/:userUuid -> /user/{userUuid}

ZeRego avatar Nov 28 '22 16:11 ZeRego

Hey! Yes, we're working on that :) Currently our endpoint detection is based on some "magic" in the backend but we'll push this down to the agent level soon with our new agents... This update will also come with configurable blocking at the agent level for malicious traffic as well :) This will be coming out sometime next week and I'll update here once its ready.

I know this isn't ideal but for now you can upload Open API specs manually on the Open API Specs Tab.

akshay288 avatar Nov 28 '22 20:11 akshay288