meteor-react-native icon indicating copy to clipboard operation
meteor-react-native copied to clipboard

autoConnect is broken

Open jankapunkt opened this issue 1 year ago • 2 comments

Describe the bug setting autoConnect to false will still cause an auto connect. This is, because autoConnect is implemented in DDP and Meteor.connect and while in DDP class it will respect the autoConnect flag, it won't in Meteor connect.

To Reproduce

Meteor.connect(url, {
  ...
  autoConnect: false,
  ...
})

const Data = Meteor.getData()
Data.ddp.on('connected', () => {
  console.debug('this should never fire')
})

Expected behavior autoConnect set to false should prevent auto connect.

jankapunkt avatar Feb 13 '24 14:02 jankapunkt

@bratelefant should I implement the fix in #147 or in an own PR?

jankapunkt avatar Feb 13 '24 14:02 jankapunkt

I guess it's fine if we merge this in as well. Found out that I patched this in my app manually, would like to test the complete bundle in staging as well

bratelefant avatar Feb 13 '24 14:02 bratelefant

Closing this issue due to no activity. Feel free to reopen.

github-actions[bot] avatar Apr 14 '24 03:04 github-actions[bot]

keep open

jankapunkt avatar Apr 14 '24 10:04 jankapunkt