meteor-feature-requests icon indicating copy to clipboard operation
meteor-feature-requests copied to clipboard

Upgrade SockJS (client/server)

Open hwillson opened this issue 8 years ago • 3 comments

Feature request https://github.com/meteor/meteor-feature-requests/issues/41 tracks the idea of potentially replacing SockJS with something else, but in the meantime (and given the number of open SockJS issues/PR), there's a good chance we'll take the (hopefully) easier path of just upgrading SockJS for now.

Let's use this FR to track a SockJS upgrade, and combine the requirements from the other open SockJS issues, to make sure we don't miss anything (and to allow us to close the SockJS FR's in the main Meteor issue repo).

This issue supersedes:

  • https://github.com/meteor/meteor/issues/4114
  • https://github.com/meteor/meteor/issues/8254

SockJS Client Upgrade

  • Meteor is currently using a local copy of the SockJS client library, that includes several custom changes. It looks like a lot of the custom changes made were accepted back upstream, but this will need to be verified / tested. Ideally the use of a local SockJS client copy is discontinued, and the most recent version of the sockjs-client npm package is leveraged instead.
  • There was some initial investigative work done with regards to upgrading the SockJS client, out of which came some concerns around the new client size. See https://github.com/meteor/meteor/issues/4114#issuecomment-273253377 for details.

SockJS Server Upgrade

  • Meteor's SockJS server dependency (the sockjs npm package) should be upgraded. PR https://github.com/meteor/meteor/pull/9215 has been started to address this.

hwillson avatar Nov 06 '17 02:11 hwillson

how about ws

https://github.com/websockets/ws

https://npmcompare.com/compare/derby,socket.io,sockjs,websocket-node,ws

crapthings avatar Nov 06 '17 04:11 crapthings

Thanks @crapthings - replacing SockJS is being tracked in https://github.com/meteor/meteor-feature-requests/issues/41, which includes some discussion about https://www.npmjs.com/package/ws. That might be a good choice!

hwillson avatar Nov 06 '17 11:11 hwillson

@hwillson I think this can be closed?

KoenLav avatar Apr 13 '19 22:04 KoenLav