Carlos Fuentes comments

Results 528 comments of


                                            Carlos Fuentes

Cache interceptor failing with "invalid onError method"

>My theory is that somehow undic / fetch gets loaded in Node.js core before the one on the first line. Anyhow, we should be able to handle this Yeah, that's...

chore: Migrate tests from Tap to `node:test`

Closed by #792

server.close in HTTP2 does not close active sessions, they need to be closed manually

You also need to wait until sessions are closed (e.g. `await once(session, 'close')`), otherwise not all sessions might be closed when server attempts to destroy the socket.

server.close in HTTP2 does not close active sessions, they need to be closed manually

>Should this be a fastify package, or coded in the core? As this is an inconsistency on the expectations while handling H2 server, I believe this should be fixed in...

Reduce Buffer operations in EventSource

The solution from the PR seems to be of help for the usage of `concat`, but a way to iterate over the buffer to consume it while avoiding subarrays might...

fix: improve parsing content-range header

Sadly I don't see much room for improving the current `range` parsing implementation. The only improvement is to replace it with the `fetch` one and adjust accordingly, so we have...

fix: improve parsing content-range header

Sure, that SGTM 👍

Create official tutorial on the documentation website

>I could be wrong, but I think ESM is increasingly the default for modern Node.js applications. If this is the case, is it necessary to present both? What would be...

Drain does not always work (race conditions?)

Hmm, this looks more like an event loop lag condition. The `needsDrain` and `drain` event are emitted synchronously; so if the loop is blocked enough (Which could be the cause)...

Drain does not always work (race conditions?)

Yeah, that's also possible with the current setup; offloading it to the `queueMicrotask` will help delay the execution so listeners can subscribe on time, and events can be emitted before...