digital-asset-validator-plugin icon indicating copy to clipboard operation
digital-asset-validator-plugin copied to clipboard

Add flag to not emit metric by accounts and flag to push accounts to messenger without caching

Open vovkman opened this issue 1 year ago • 3 comments

Add flag to not emit metric by accounts and flag to push accounts to messenger without caching

vovkman avatar Apr 05 '23 17:04 vovkman

This cache accounts by slot param though does it really make sense?

The issue is that it conflicts with the commitment level setting - so instead of adding a flag couldn't you just check if config.commitment_level == processed and in that case ignore the cache.

linuskendall avatar Apr 05 '23 19:04 linuskendall

I think the cache by slot setting need to take into account commitment level. I would remove this new param and instead have the same behaviour if commitment level is set to processed.

This makes sense to me, it just changes behavior from current state processed where it will flatten account updates per slot. If we are okay with that then I will make the change

vovkman avatar Apr 05 '23 19:04 vovkman

Yeah if commitment level is set to processed it seems logical to me to push account updates as soon as they are seen.

linuskendall avatar Apr 05 '23 19:04 linuskendall

I think this PR is too old now. Feel free to reopen it if you are still interested in this behavior! Thank you for your contributions in general!

danenbm avatar Sep 06 '24 08:09 danenbm