loki-kube-prometheus icon indicating copy to clipboard operation
loki-kube-prometheus copied to clipboard

Is there anything special about your image of Loki or Promtail?

Open CarlQLange opened this issue 5 years ago • 5 comments

In your config, the only thing I see that worries me is that the Loki image is your own: quay.io/metalmatze/loki:20190411, and also promtail: quay.io/metalmatze/promtail:20190411. Can this be replaced with the standard official image, or is there something special about your fork?

Thanks for your work on this, it's surprising the kube-prometheus team haven't added Loki themselves.

CarlQLange avatar Oct 03 '19 08:10 CarlQLange

Those images were copied during a time when there only was a loki master image available that was overwritten on every push. I wanted things to stabilize at least to some degree, that's why I created these snapshots. But they are exactly what master was at that time.

We should indeed update this repository to work with the latest images and contain the latest manifests. In the end it would also make sense to see if upstream Loki ksonnet is independent from Consul and some other dependencies at that time.

metalmatze avatar Oct 03 '19 10:10 metalmatze

Ah, I see, very interesting. I didn't see anything related to Consul when researching this, maybe that was an older method. Have you continued to use Loki with kube-prometheus? Any problems? Thanks a lot!

CarlQLange avatar Oct 03 '19 11:10 CarlQLange

Yes, Consul and some other dependencies were in there when they released it way back in December. In the last few months my focus was mostly on kube-thanos which recently moved upstream. But I am very happy to continue here and make sure it works with recent versions.

metalmatze avatar Oct 03 '19 11:10 metalmatze

Indeed, it looks like Consul is still used. It would be really great to have a way to use loki with kube-prometheus with no hassle!

CarlQLange avatar Oct 03 '19 18:10 CarlQLange

Yes. That's exactly the reason why I started the project. Happy to receive PRs, but maybe I can work on it a bit in the next days! 😊

metalmatze avatar Oct 03 '19 20:10 metalmatze