Matthias Loibl
Matthias Loibl
Please add some tests that show the entire pipeline. Add a test case in this file: https://github.com/pyrra-dev/pyrra/blob/main/slo/rules_test.go#L13
Thanks! This great! It needs rebase. > As far as I know, VictoriaMetrics understands the same query language as Prometheus, so I use the same rule generation logic and just...
This touches on a fundamental design decision in Pyrra that's worth explaining. Pyrra implements **window-based SLOs** (rolling windows) rather than **calendar-based SLOs** (fixed quarters/months) primarily due to Prometheus's architecture and...
Thanks for reporting. We'll look into that!
There's no way of configuring this today. There's another issue to support different level for the individual burn rates. We could add an option to have a null level too...
The comment was from a year ago. I believe we have resolved all the outstanding issues. Nice work!
Thanks! From looking at the code changes and now having compiled and run this, the change seems good overall. :+1: Some CI failures need to be fixed. Run `jsonnetfmt -i...
kube-thanos is based on jsonnet and extends kube-prometheus. As part of kube-prometheus, the Prometheus Operator gets deployed, which is most likely the pieces you're missing.
Any first impressions @gabor @yesoreyeram @ivanahuckova?
Addressed most comments. Thank you for your patience. I'm a bit swamped with other Polar Signals things and organizing PromCon on the side.