go-ipam icon indicating copy to clipboard operation
go-ipam copied to clipboard

Published 20 hours ago • verified publisher icon metal-stack

Upstream multi ip manipulation in one redis transaction

Open dzvancuks opened this issue 2 years ago • 3 comments

  • Added interface to acquire and release multiple IP in single DB transaction.
  • Updated Redis module so that it wont throw error in case DB has other keys.

dzvancuks avatar Jun 14 '22 14:06 dzvancuks

General note: in case you think that such changes are not required just reject PR, I will just keep them in fork.

dzvancuks avatar Jun 15 '22 11:06 dzvancuks

General note: in case you think that such changes are not required just reject PR, I will just keep them in fork.

Sure this is always possible, but i like to have meaningful contributions. What do you think about my grpc server approach, the PR #46 must be adopted to current main but overall this is in my opinion the fastest possible way.

majst01 avatar Jun 15 '22 11:06 majst01

@majst01 also please note that we need to have correct Redis key read. Please recommend: should we wait for https://github.com/metal-stack/go-ipam/pull/43 or shoud I implement Redis Storage options?

dzvancuks avatar Jun 28 '22 12:06 dzvancuks