Dark-Souls-1-Overhaul icon indicating copy to clipboard operation
Dark-Souls-1-Overhaul copied to clipboard

Disabling armor sounds alters gameplay

Open metal-crow opened this issue 6 years ago • 1 comments

The, currently default enabled, disable armor noises patch causes enemies to also not perceive armor noises, instead of just being a ascetic patch. This alters game play since enemies heavily rely on this noise to detect players.

metal-crow avatar Jan 03 '18 21:01 metal-crow

Currently the armor sound effect patch alters the armor parameter file (ProtectorParam.param) in memory to disable the sound effects. For possible fixes, we should try one (or more) of the following:

  • Edit the SpEffect parameter file or sound file directly, rather than the ArmorParam file
  • ~Double check that Zullie's original script has the same issue. If not, there may be a problem with the ArmorParam C++ structure I created. This was my first param structure conversion, created before I had a full understanding of the way param files worked. For this reason, the ArmorParam structure may have some bugs or misplaced member data.~ Confirmed, original CE script has the same issue

Additionally, I never intended for the armor sounds patch to be enabled by default; I must have accidentally enabled it in the config file when distributing the latest DLL build. Whether or not the patch works, we should have it disabled by default.

SeanPesce avatar Jan 04 '18 14:01 SeanPesce