gyft2 icon indicating copy to clipboard operation
gyft2 copied to clipboard

Doesn't ignore the saved html files and folders

Open xypnox opened this issue 6 years ago • 3 comments

The timetable page and the folder for the files are currently not ignored in .gitignore.

Add specific rules to ignore these files. Note that the name of the files is different for every student. In my case it was: Welcome Aditya Vikram Singh to ERP, IIT Kharagpur.htm and the folder was named similarly.

xypnox avatar Aug 30 '19 14:08 xypnox

I don't have that much knowledge of html,so pardon for not any mistake, But i think the file the code is looking for is not the Welcome.....htm one but there is a .html file inside the dir "Welcome ...", that was the main problem which i faced when i tried to use it in my case, then i looked into the code and then searched the file with the req name in the downloaded files then i got the problem... And btw even if it was the case with the same name i couldn't get the real problem as the code is looking for a file not a dir so it will automatically ignore the folder with the same name...

Raghwendra-Dey avatar Aug 30 '19 19:08 Raghwendra-Dey

I am not talking about ignoring the file by the python code. I am referring to ignoring files by git. You can read more about it here: https://www.atlassian.com/git/tutorials/saving-changes/gitignore

This is essential because we do not want some contributor's files to be committed in the git repository. Hence we add rules in the .gitignore so that git automatically ignores the file and doesn't add it to the staging area.

On Sat, 31 Aug 2019 at 01:06, Raghwendra Dey [email protected] wrote:

I don't have that much knowledge of html,so pardon for not any mistake,

But i think the file the code is looking for is not the Welcome.....htm one but there is a .html file inside the dir "Welcome ...", that was the main problem which i faced when i tried to use it in my case, then i looked into the code and then searched the file with the req name in the downloaded files then i got the problem... And btw even if it was the case with the same name i couldn't get the real problem as the code is looking for a file not a dir so it will automatically ignore the folder with the same name...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/xypnox/gyft2/issues/6?email_source=notifications&email_token=AF7KDS6XDFUZ7DX6XAUVHMDQHFZFVA5CNFSM4ISOETJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5SSPHQ#issuecomment-526722974, or mute the thread https://github.com/notifications/unsubscribe-auth/AF7KDSZBWBLN3HF7O7WHACTQHFZFVANCNFSM4ISOETJQ .

xypnox avatar Aug 30 '19 20:08 xypnox

Sorry, but i still didn't completely understand.... The problem you are taking about is created due to my patch or it already existed? And sorry for late reply i was busy due to acads .

Raghwendra-Dey avatar Sep 01 '19 19:09 Raghwendra-Dey