gyft2 icon indicating copy to clipboard operation
gyft2 copied to clipboard

Update dates.py 2024->2025

Open JebronLames32 opened this issue 1 year ago • 6 comments

Current code is generating ics starting from Jan 2, 2024. Replaced this date to Jan 2, 2025

JebronLames32 avatar Dec 30 '24 18:12 JebronLames32

@shikharish @rohan-b-84 I have lost track on the development of this, are there any other changes required?

proffapt avatar Dec 31 '24 08:12 proffapt

@JebronLames32 The dates have to updated from the academic calendar. Just changing 2024->2025 won't do.

shikharish avatar Dec 31 '24 13:12 shikharish

@shikharish All the dates seem to be hardcoded. I saw that there was a PR in the original gyft repository Pull Request #147 which addresses this issue but not completely I think. the hardcoding part of the start and end dates still has to be changed. A similar fix can be incorporated here as well. Changing the date from 2024 to 2025 seemed like a temporary fix for this issue as it does not seem to be taking any holidays into account while making the ics and provided me an accurate looking schedule.

JebronLames32 avatar Dec 31 '24 13:12 JebronLames32

The correct dates for midsem and endsem exams is still wrong and the timetable won't be fully correct. For now, you can hardcode the actual dates from the academic calendar. And if you are interested in implementing the parsing part, feel free to open an issue for it! Thanks.

shikharish avatar Dec 31 '24 13:12 shikharish

Sure! Will take a look at it

JebronLames32 avatar Dec 31 '24 13:12 JebronLames32

The parsing part is on another PR. You don't have to look at it, update the latest dates from the calendar.

proffapt avatar Jan 02 '25 14:01 proffapt