flickity icon indicating copy to clipboard operation
flickity copied to clipboard

Published 20 hours ago • verified publisher icon metafizzy

Feature/watch visibility

Open pooriamo opened this issue 5 years ago • 10 comments

This feature adds or removes the className is-visible based on cells' condition.

pooriamo avatar Feb 25 '20 16:02 pooriamo

Thanks so much for this contribution. This has been requested several times. I'll be evaluating adding this feature in the next minor release.

desandro avatar May 14 '20 17:05 desandro

@desandro, great! And when will that be?

larscmagnusson avatar May 25 '20 03:05 larscmagnusson

@larscmagnusson Could this PR be updated to also properly add/remove the aria-hidden attribute based on the cell visibility?

bakura10 avatar Sep 10 '20 14:09 bakura10

@desandro once this PR is updated to handle the aria-hidden could it be merged? If a given slide with aria-hidden=true contains focusable elements, Lighthouse now returns this as an accessibility issue. A simple fix would be to set aria-hidden elements to visibility: hidden, but the fact that Flickity currently does not handle the aria-hidden attribute correctly prevent us to do that :(

bakura10 avatar Sep 10 '20 14:09 bakura10

@jenswittmann Done

pooriamo avatar Nov 02 '20 08:11 pooriamo

I would love to see this issue resolved.

danimalweb avatar Mar 18 '21 17:03 danimalweb

Any updates on this?

dpw1 avatar Mar 27 '21 02:03 dpw1

Is there any update on this?

ranuss avatar Feb 22 '22 08:02 ranuss

Can we merge this please? Would love to have this issue fixed!

MizuBishi avatar Feb 22 '22 08:02 MizuBishi

What is the status on this issue? We are using Flickity and are getting flagged for accessibility.

haase1020 avatar Apr 24 '22 09:04 haase1020