mangal icon indicating copy to clipboard operation
mangal copied to clipboard

Unable to find Manga title with a Comma and Exclamation Mark

Open Ponkhy opened this issue 2 years ago • 1 comments

Describe the bug

Hello,

it seems like Mangal is unable to find any Manga with a Comma and/or Exclamation Mark in the title. Is there a way to fix this issue? I wanted to use this project kaizoku, but I'm unable to add any anime to the library because Mangal can't find the exact title.

Many thanks!

Reproduction steps

No response

Expected behavior

No response

Additional context

No response

Operating System

Linux

Ponkhy avatar Jan 28 '23 16:01 Ponkhy

Seems that the issue is in the "provider/mangapill/mangapill.go".

The line 19, we have query = strings.ReplaceAll(query, " ", "+"), that is causing the problem, because in the line 23, we already escape empty spaces by "+" signal (url.QueryEscape(query)).

As you can see in the example below, we have two URLs, one I did comment out he line 19, and the other one is the original code.

  • Works: https://mangapill.com/search?q=rurouni+kenshin&type=&status=
  • Don't work: https://mangapill.com/search?q=rurouni%2Bkenshin&type=&status=

Command: mangal inline --source Mangapill --query 'Rurouni Kenshin' --manga exact --json

andrelom avatar Jan 16 '24 02:01 andrelom