Chris Hager comments

Results 231 comments of


                                            Chris Hager

Run gocritic linter

`staticcheck` has been a reliable, helpful tool. I don't see a need for removing it.

Just tried to confirm this, and saw this on https://golangci-lint.run/usage/linters/: > staticcheck: It's a set of rules from staticcheck. It's not the same thing as the staticcheck binary. The author...

Run gocritic linter

why remove `go vet`?

Run gocritic linter

i think this cleanup PR is still good to have, if all the tests are done in golangci-lint. it looks like actually all the staticcheck and vet tests are run...

Run gocritic linter

@estensen can you link to documentation that shows that the `vet` rules in golangci-lint are equivalent to `go vet`? How about staticcheck? I'm for removing redundant tools and checks, as...

Run gocritic linter

thanks!

Add more linters

sounds good. see also https://github.com/flashbots/mev-boost-relay as reference

Allow setting a minimum bid value to determine whether or not to use a block supplied by the builder API

Thanks for the contribution! And sorry for being slow to respond on this. It was on the radar, but due to the merge there were so many other priorities. I...

Allow setting a minimum bid value to determine whether or not to use a block supplied by the builder API

for reference, this is the EL APIs issue: https://github.com/ethereum/execution-apis/issues/307 about exposing the block value

feat: have all config/consts together, and print on startup

Wow, very cool! Please open a PR 🙏