core icon indicating copy to clipboard operation
core copied to clipboard

add base support for cli plugin architecture

Open rxbryan opened this issue 3 years ago • 5 comments

Description

add base support for cli plugin architecture add support for building metacallcli-bootstrap

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] This change requires a documentation update
  • [ ] Documentation update

Checklist:

  • [x] I have performed a self-review of my own code.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [x] My changes generate no new warnings.
  • [ ] I have added tests/screenshots (if any) that prove my fix is effective or that my feature works.
  • [ ] I have tested the tests implicated (if any) by my own code and they pass (make test or ctest -VV -R <test-name>).
  • [ ] If my change is significant or breaking, I have passed all tests with ./docker-compose.sh build &> output and attached the output.
  • [ ] I have tested my code with OPTION_BUILD_SANITIZER or ./docker-compose.sh test &> output and OPTION_TEST_MEMORYCHECK.
  • [ ] I have tested with Helgrind in case my code works with threading.
  • [x] I have run make clang-format in order to format my code and my code follows the style guidelines.

If you are unclear about any of the above checks, have a look at our documentation here.

rxbryan avatar May 05 '22 23:05 rxbryan

This pull request introduces 8 alerts when merging 8c5c4634f4b491bd89682a6d81777a073e7576d5 into bed04b908708b56d47a5b82cdff9f5739df8f6bc - view on LGTM.com

new alerts:

  • 7 for Missing variable declaration
  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar May 05 '22 23:05 lgtm-com[bot]

This pull request introduces 8 alerts when merging 8c5c4634f4b491bd89682a6d81777a073e7576d5 into bed04b908708b56d47a5b82cdff9f5739df8f6bc - view on LGTM.com

new alerts:

  • 7 for Missing variable declaration
  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar May 05 '22 23:05 lgtm-com[bot]

This pull request introduces 8 alerts when merging 94c550376631d756116e3ae8ff13a02258cc70cf into bed04b908708b56d47a5b82cdff9f5739df8f6bc - view on LGTM.com

new alerts:

  • 7 for Missing variable declaration
  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar May 06 '22 00:05 lgtm-com[bot]

This pull request introduces 2 alerts when merging 6bb470cfc6bbd5c064bc5bf0de79863c28d4fd25 into bed04b908708b56d47a5b82cdff9f5739df8f6bc - view on LGTM.com

new alerts:

  • 1 for Missing variable declaration
  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar May 06 '22 08:05 lgtm-com[bot]

It looks pretty good for now, I want to wait until it is further developed in order to merge it but it is going well.

viferga avatar May 12 '22 12:05 viferga