picard-plugins
picard-plugins copied to clipboard
metabrainz
Calculated ReplayGain values do not show up in Tag Editor
When using the ReplayGain plugin, the calculated values are not listed in the Tag Editor area at the bottom of the Picard window. A user would expect that the new values show up in green color on the right side.
I'm using ArchLinux and these versions: MusicBrainz Picard 1.4 PyQt 4.12 Qt 4.8.7 Mutagen 1.37 ReplayGain Plugin 0.1
This is because the tags from the files are not immediately reloaded after the replaygain calculation utility has finished.
IMHO it would be better if ReplayGain tags are not saved until the user hits the "Save" button.
When using MP3 files, this is possible by invoking mp3gain with the -s s argument, so that tags are not changed:
$ mp3gain -s s -o -q *.mp3
File MP3 gain dB gain Max Amplitude Max global_gain Min global_gain
somefile1.mp3 -5 -7.290000 34802.173241 255 142
somefile2.mp3 -5 -7.250000 36258.364289 255 147
somefile3.mp3 -5 -8.180000 37765.563247 255 146
somefile4.mp3 -6 -9.350000 36827.307860 255 141
"Album" -5 -7.910000 37765.563247 255 141
The plugin can parse the output and update the tag editor.
Likewise, we could use metaflac --scan-replay-gain, wvgain -a -d and vorbisgain -a -d to display the calculated values instead of writing them directly.
I second that, @Holzhaus. Are there any plans to address this? It seems wrong to me that the plugin just bypasses picard and writes the files on its own.
My whole music library is synchronized across several devices using nextcloud, I carefully review changes made to the files, because just touching a file (i.e., writing it without semantically changing any tag) forces a re-sync with nextcloud. I cannot do this with the replaygain plugin because it will just brute-force changes instead of allowing me to review if anything even changed to given files.
@charlydelta There have been discussions about this, see e.g. https://community.metabrainz.org/t/help-with-replaygain-plugin/446469/5 . I hope @Sophist-UK finds the time for it.
Great, thanks for the link! Yes would be really awesome, but I understand that the current workflow is convenient for many.
As and when I have time, my plan is to plagiarise (with permission) the regainer code and use @phw 's ffmpeg image in order to calculate the replay gain values and put them into the correct Picard variables so that they are only saved when you click Save in Picard.
If possible (and I haven't looked at whether this is possible or not) I will try to include the additional tags calculated by loudgain as defined here.
This has been addressed with the new replaygain2 plugin (which will be available for download in a few hours). See #336 for details.
The old replaygain plugin is considered deprecated and will be removed in the future.