musicbrainz-server icon indicating copy to clipboard operation
musicbrainz-server copied to clipboard

MBS-12898: Autoselect Apple Music rel for artists/labels

Open reosarevok opened this issue 2 years ago • 3 comments

Implement MBS-12898

Problem

Apple Music artist/label pages work in a very similar way to Bandcamp artist/label pages, in that the music can be available for streaming, or download, or both, or neither, and the contents can often change so that the right relationship would also change fairly often. As with Bandcamp though, the most important thing to denote is that the artist/label has an Apple Music page at that URL, so a new Apple Music relationship type has been added for artists and labels mirroring the Bandcamp one.

The current autoselect code though still selects purchase for download / streaming page, meaning the new relationship types cannot yet be used.

Solution

This follows the Bandcamp model of autoselect and autoselects the new Apple Music relationship types instead.

Action

  • [ ] Run MBBE-70 either just after this is in beta or just after this is in production to migrate existing links

Documentation

Testing

Updated the URL handling tests accordingly.

Notes

On top of https://github.com/metabrainz/musicbrainz-server/pull/2825 since it uses the multi-option code introduced there.

reosarevok avatar Feb 13 '23 13:02 reosarevok

The reason to have its own rel for this at the artist level is not related to that but with the Bandcamp case - this can be sometimes stream, sometimes download and sometimes both and we should not expect users to keep those changes up to date at the artist level.

That ticket is why this was only added for artist/label and not for recording / release where we are instead going with a multiple select option (again like with Bandcamp) :)

reosarevok avatar Jul 26 '23 19:07 reosarevok

is not related to that

It is exactly the same issue but for a specific website.

Your recent proposition to make the parent “get the music” selectable makes much more sense.

yvanzo avatar Jul 27 '23 16:07 yvanzo

That ticket was about splitting things that belong under one specific rel type into further sub types for every site. This is specifically a site that does not work under the current structure in that way and needs a separate relationship. The relationship has also already existed for months, and its use is being blocked by this.

Of course moving everything under get the music makes a lot of sense to you since you seem to want to delete all per-site relationship types anyway, but I have seen nobody else ask for such a change and a separate rel for this was explicitly requested (STYLE-801). As such, I would be thankful if I was allowed to continue doing my job as style leader by implementing the second part of that ticket. Alternatively, if you would like to do the job of style leader, we can talk about it and see what Rob thinks about it - it's not something I love doing and if you're excited about taking these sorts of decisions I wouldn't mind you taking over it.

reosarevok avatar Jul 27 '23 16:07 reosarevok